Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create hover view #836

Merged
merged 9 commits into from
Jan 24, 2024
Merged

feat: create hover view #836

merged 9 commits into from
Jan 24, 2024

Conversation

KevinWu098
Copy link
Member

@KevinWu098 KevinWu098 commented Dec 7, 2023

WIP To-Dos

  • Show all meetings of the section
  • Handle hovered sections that are already added
  • Disable in added pane (possibly solved by task 2)
  • Make not an eyesore

Summary

  1. Implement a HoveredStore to store the currently hovered course
  2. SectionTableBody will access and update HoveredStore when a section is hovered
  3. Hovered Courses will be appended to events passed to the Calendar

chrome-capture-2023-11-6 (1)

Test Plan

  1. Check that it correctly displays the course on the calendar
  2. Light and Dark mode compatibility
  3. Doesn't activate on Added Pane
  4. Doesn't activate on already added courses

Issues

Closes #828

Future Followup

  1. Remove the schedule conflict feature, since this covers much of the same functionality? Unsure on this (since SC is my baby 🥺, but it's a valid question)

@KevinWu098 KevinWu098 marked this pull request as ready for review December 7, 2023 02:14
@KevinWu098 KevinWu098 requested a review from EricPedley December 7, 2023 04:59
Copy link
Member

@EricPedley EricPedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, but I think the classes instantly showing up looks a little jarring. I think we should add a delay before the class shows up previewed on the calendar and maybe an animation to fade it in. We can bring this up in the meeting tomorrow to get more input on what to do from a UI/UX perspective here.

@KevinWu098 KevinWu098 requested a review from EricPedley December 8, 2023 08:48
@KevinWu098
Copy link
Member Author

TL;DR of latest changes:

  1. "Hovered" courses are now 80% opacity
  2. Settings Menu has some updated styling
  3. Preview Mode is now in settings menu, defaulting false

I've chosen not to move Schedule Conflict into the experimental menu, as after some further thought, I agree with Eric on that it's a feature people have gotten used to, but I'm happy to circle back to that as needed

@github-actions github-actions bot added the Stale label Jan 11, 2024
Copy link
Member

@EricPedley EricPedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok one more small change: can we call the toggle in the settings menu "Hover to Preview" instead of "Preview Mode"? I think it makes it more clear what it does. LMK if you agree or not. After we decide this, good to merge.

@github-actions github-actions bot removed the Stale label Jan 24, 2024
@EricPedley EricPedley merged commit 08a9bdc into main Jan 24, 2024
6 checks passed
@EricPedley EricPedley deleted the hover-course-view-in-calendar branch January 24, 2024 21:37
MinhxNguyen7 pushed a commit that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Hovered courses Appear on the Calendar
2 participants