-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create hover view #836
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine, but I think the classes instantly showing up looks a little jarring. I think we should add a delay before the class shows up previewed on the calendar and maybe an animation to fade it in. We can bring this up in the meeting tomorrow to get more input on what to do from a UI/UX perspective here.
TL;DR of latest changes:
I've chosen not to move Schedule Conflict into the experimental menu, as after some further thought, I agree with Eric on that it's a feature people have gotten used to, but I'm happy to circle back to that as needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok one more small change: can we call the toggle in the settings menu "Hover to Preview" instead of "Preview Mode"? I think it makes it more clear what it does. LMK if you agree or not. After we decide this, good to merge.
WIPTo-DosSummary
HoveredStore
to store the currently hovered courseSectionTableBody
will access and updateHoveredStore
when a section is hoveredTest Plan
Issues
Closes #828
Future Followup