Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor Import #844

Merged
merged 8 commits into from
Jan 29, 2024
Merged

feat: refactor Import #844

merged 8 commits into from
Jan 29, 2024

Conversation

KevinWu098
Copy link
Member

@KevinWu098 KevinWu098 commented Dec 11, 2023 •
edited
Loading

Summary

  1. Refactored Import
  2. Refactored Term Selector
  3. Import now subscribes to AppStore for SkeletonMode, and disables appropriately

Test Plan

  1. Terms should be correctly set from the url, when loading in
  2. Terms should update correctly when using the Select element
  3. Import should be disabled when in Skeleton Mode (use firefox dev tools, or change the api endpoint)

Issues

Closes #771

@KevinWu098 KevinWu098 changed the title feat: initial refactor of Import (WIP) feat: refactor of Import (WIP) Dec 11, 2023
@KevinWu098 KevinWu098 changed the title feat: refactor of Import (WIP) feat: refactor Import (WIP) Dec 11, 2023
@KevinWu098 KevinWu098 changed the title feat: refactor Import (WIP) feat: refactor Import Dec 14, 2023
@KevinWu098 KevinWu098 marked this pull request as ready for review December 14, 2023 09:43
@github-actions github-actions bot added the Stale label Jan 13, 2024
Douglas-Hong
Douglas-Hong approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@Douglas-Hong Douglas-Hong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just remove one little line and this is good to go!

apps/antalmanac/src/components/Header/Import.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the Stale label Jan 25, 2024
@Douglas-Hong Douglas-Hong merged commit e5c42c5 into main Jan 29, 2024
6 checks passed
MinhxNguyen7 pushed a commit that referenced this pull request Jan 31, 2024
@KevinWu098 @MinhxNguyen7
feat: refactor Import (#844)
fcaa56a
@EricPedley EricPedley deleted the 771-refactor-import branch February 6, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Douglas-Hong Douglas-Hong Douglas-Hong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable Import in Skeleton Mode, Subscribe to Skeleton Mode
2 participants
@KevinWu098 @Douglas-Hong