fix: colorpicker no longer closes on click #851
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously,
handleClosePopover()
would never be triggered asclose
always evaluated to false, even when no param was passed intoupdateEventsInCalendar
. In the refactor, I omitted a check, since I expected nothing would change... hahaTo whomever is reviewing this PR, if you can explain to me why that is the case when
close = true
in the snippet, please let me know.Test Plan
Issues
Bug Report: https://discord.com/channels/772739905981644850/780316580819107860/1192200165948395561