-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show all past enrollment graphs #867
Conversation
Deployed staging instance to https://staging-867.antalmanac.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks solid 💯
Most concerns are just style and preference.
apps/antalmanac/src/components/RightPane/CoursePane/CourseRenderPane.tsx
Outdated
Show resolved
Hide resolved
apps/antalmanac/src/components/RightPane/SectionTable/EnrollmentHistoryPopup.tsx
Outdated
Show resolved
Hide resolved
apps/antalmanac/src/components/RightPane/SectionTable/EnrollmentHistoryPopup.tsx
Outdated
Show resolved
Hide resolved
apps/antalmanac/src/components/RightPane/SectionTable/EnrollmentHistoryPopup.tsx
Outdated
Show resolved
Hide resolved
apps/antalmanac/src/components/RightPane/SectionTable/EnrollmentHistoryPopup.tsx
Show resolved
Hide resolved
apps/antalmanac/src/components/RightPane/SectionTable/EnrollmentHistoryPopup.tsx
Outdated
Show resolved
Hide resolved
apps/antalmanac/src/components/Calendar/Toolbar/CustomEventDialog/CustomEventDialog.tsx
Outdated
Show resolved
Hide resolved
apps/antalmanac/src/components/RightPane/SectionTable/EnrollmentHistoryPopup.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the enhancement 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good changes 👍
Great feature, but I'm very confused about the arrow placement? Why are past enrollments navigated to with the right arrow and vice versa? It seems very unintuitive, and after some user testing, 5/5 users immediately went towards the lefthand side when asked to show me a prior quarter's courses. @Douglas-Hong Can we swap it around? |
@KevinWu098 that's a good point. I also thought about this a lot when I was implementing the feature. Here is my thought process: first, I want to show the most recent quarter's enrollment data when the popup is opened since the most recent quarters are probably more relevant. Then, I thought it would be awkward to have the right arrow instead of the left arrow be disabled when the popup first appears because normally that implies we have reached the end of a list. Therefore, instead of having the list be from oldest quarter to most recent quarter, I thought it would be better to go from most recent quarter to oldest quarter. I'm not sure if that makes sense, lmk if you need any clarification. However, based on the user testing, I think it's a good idea to swap the arrows. @EricPedley @ap0nia do you guys have any opinions about this? |
Your reasoning makes sense, but I think we have to defer to the "default user behavior" of "older being lefter" |
I agree that older should be left. |
Summary
TODO
Test Plan
Issues
Closes #830
Future Follow-up