Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all past enrollment graphs #867

Merged
merged 14 commits into from
Feb 23, 2024
Merged

Show all past enrollment graphs #867

merged 14 commits into from
Feb 23, 2024

Conversation

Douglas-Hong
Copy link
Contributor

@Douglas-Hong Douglas-Hong commented Jan 28, 2024

Summary

  • The user can navigate back and forth between all the past enrollment graphs for a specific course

image

TODO

  • Show all past enrollment graphs
  • Improve the design for mobile

Test Plan

  • Verify this works for classes in the most recent quarter (e.g. CS 143A).
  • Verify this works for classes that haven't been offered very recently (e.g. CS 122D from Spring 2023).
  • Make sure the modal looks good on mobile and light/dark mode.

Issues

Closes #830

Future Follow-up

  • I tried to add an instructor filter, but Material UI has problems when we add a select menu to a popper. We can tackle this later. Or, we can just not implement it because it would clutter the popper, and the user can go to ZotTracker for more advanced searching.

Copy link
Contributor

Deployed staging instance to https://staging-867.antalmanac.com

@Douglas-Hong Douglas-Hong changed the title Show all past enrollment graphs and add instructor filter Show all past enrollment graphs Feb 7, 2024
@Douglas-Hong Douglas-Hong marked this pull request as ready for review February 9, 2024 18:42
@github-actions github-actions bot requested a review from MinhxNguyen7 February 9, 2024 18:42
@Douglas-Hong Douglas-Hong requested a review from ap0nia February 9, 2024 18:42
Copy link
Collaborator

@ap0nia ap0nia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks solid 💯

Most concerns are just style and preference.

@Douglas-Hong Douglas-Hong requested a review from ap0nia February 19, 2024 09:34
@MinhxNguyen7 MinhxNguyen7 removed their request for review February 21, 2024 21:35
Copy link
Collaborator

@ap0nia ap0nia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the enhancement 💯

Copy link
Collaborator

@ap0nia ap0nia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes 👍

@ap0nia ap0nia merged commit 7727f8d into main Feb 23, 2024
5 checks passed
@ap0nia ap0nia deleted the multiple-enrollment-graphs branch February 23, 2024 20:02
@KevinWu098
Copy link
Member

KevinWu098 commented Feb 23, 2024

Great feature, but I'm very confused about the arrow placement?

Why are past enrollments navigated to with the right arrow and vice versa? It seems very unintuitive, and after some user testing, 5/5 users immediately went towards the lefthand side when asked to show me a prior quarter's courses.

Screenshot 2024-02-23 at 12 45 01 PM

@Douglas-Hong Can we swap it around?

@Douglas-Hong
Copy link
Contributor Author

Douglas-Hong commented Feb 24, 2024

@KevinWu098 that's a good point. I also thought about this a lot when I was implementing the feature. Here is my thought process: first, I want to show the most recent quarter's enrollment data when the popup is opened since the most recent quarters are probably more relevant. Then, I thought it would be awkward to have the right arrow instead of the left arrow be disabled when the popup first appears because normally that implies we have reached the end of a list. Therefore, instead of having the list be from oldest quarter to most recent quarter, I thought it would be better to go from most recent quarter to oldest quarter. I'm not sure if that makes sense, lmk if you need any clarification.

However, based on the user testing, I think it's a good idea to swap the arrows. @EricPedley @ap0nia do you guys have any opinions about this?

@KevinWu098
Copy link
Member

@KevinWu098 that's a good point. I also thought about this a lot when I was implementing the feature. Here is my thought process: first, I want to show the most recent quarter's enrollment data since the most recent quarters are probably more relevant. Then, I thought it would be awkward to have the right arrow instead of the left arrow be disabled when the popup first appears because normally that implies we have reached the end of a list. Therefore, instead of having the list be from oldest quarter to most recent quarter, I thought it would be better to go from most recent quarter to oldest quarter. I'm not sure if that makes sense, lmk if you need any clarification.

However, based on the user testing, I think it's a good idea to swap the arrows. @EricPedley @ap0nia do you guys have any opinions about this?

Your reasoning makes sense, but I think we have to defer to the "default user behavior" of "older being lefter"

@MinhxNguyen7
Copy link
Member

I agree that older should be left.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow past enrollment popup to show the enrollment history of all previous quarters
4 participants