Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: swap to search on mobile #868

Merged
merged 2 commits into from
Jan 31, 2024
Merged

feat: swap to search on mobile #868

merged 2 commits into from
Jan 31, 2024

Conversation

KevinWu098
Copy link
Member

Summary

  1. On mobile, if a user isn't signed in, we'll default to the Classes Tab

Demo

Test Plan

  1. On mobile, check functionality both when signed in and signed out
  2. Should swap to classes tab when signed out
  3. Shouldn't swap / stay on calendar tab when signed in

Issues

Closes #858

@github-actions github-actions bot requested a review from JacE070 January 29, 2024 22:44
@KevinWu098 KevinWu098 changed the title 858 swap to search mobile feat: swap to search on mobile Jan 31, 2024
ap0nia
ap0nia approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@ap0nia ap0nia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ap0nia ap0nia merged commit a155dc1 into main Jan 31, 2024
7 checks passed
@ap0nia ap0nia deleted the 858-swap-to-search-mobile branch January 31, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ap0nia ap0nia ap0nia approved these changes

@JacE070 JacE070 Awaiting requested review from JacE070

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to search automatically on mobile when not logged in
2 participants
@KevinWu098 @ap0nia