Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementing what I was trying to explain in #847 (comment). Only the second commit is relevant.
I believe that the code written here is much more readable and should be fully comprehensible within a minute of anyone reading. It's clear, minimally-nested, and well-named.
I know that this seems like a matter of pedantry, but it genuinely took me more than 5 minutes to understand what the logic was there. Someone might come along in the future to work on this code and be even more confused. Since you already understood how the logic works, it would've only taken you a few minutes to save us much more time (and perhaps even bugs) in the future.
If you don't understand what I'm getting at and why this is important, @ap0nia can explain it to you in person.