Make area around top bar of mobile devices the same color as app bar (PWA) #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How did you test this locally as a PWA? The server seems to get completely borked when I try to access it as a PWA. I'm running Chrome on Android. @ap0nia any ideas why? 
|
|
Are you running the dev server and forwarding the port? I tried that and ran into an issue for that where the PWA was just a white screen (even when I just cloned directly from the main repo) I ended up just deploying it to Cloudflare pages via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR builds off of #834 .
The issue is that you need to explicitly tell iOS that your website is PWA capable and that you want the status bar to match the theme color in your meta tags.
Assuming you guys also want something similar on Android, you'll need to specify what color as a
theme-colormeta tag.I've applied the previously proposed colors to the manifest files and made the necessary changes to the meta tags.
Deployment Note
The PWA currently does not work off of the dev server with port forwarding, so we need to figure that out or find another way to test it.
Before and After
Test Plan
Run locally and test visually
Issues
Closes #840