Universally Thin Scrollbars for Right Pane #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This ended up being a really simple fix. To avoid creating unnecessary instances of GlobalStyles, I moved the one from CourseRenderPane.tsx into RightPaneRoot.tsx. Now all scrollbars on the right have unified thinness, which is the intended functionality, and are properly affected by one line rather than duplicate lines.
Changing the imports also has applied Prettier to the ordering of the imports for those two files. This seems to be nothing but a largely inconsequential improvement.
Edit: Apologies for the faulty PR prior to this. I have now fixed my version control and the ESLint issue I was having locally.
Test Plan
Test the styling
Search CompSci
Add a bunch of random classes
Resize the window to show horizontal scrollbars
Confirm on Search and Added that they as well as their vertical counterparts are all thin
Test the lag
Scroll all the way down on a search or CompSci then use the back arrow and confirm no lag was reintroduced
Issues
Closes #938 without breaking #902 , thereby expanding #738