Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Auth final #985

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

feat: Auth final #985

wants to merge 19 commits into from

Conversation

ap0nia
Copy link
Collaborator

@ap0nia ap0nia commented May 20, 2024 •
edited
Loading

Summary

  • Frontend implementation of auth.
  • Uses current DynamoDB without migrating to RDS yet.

Refinements

  • If user is not logged in, they should not be able to change visibility.
  • If user is not logged in, they're allowed to pick any user ID to save.
  • If user is is logged in, the user ids to save the schedule under is readonly.
  • Toggle visibility settings in account dialog.

Test Plan

Future Follow-Up

  • Migrate system to RDS.

ap0nia added 19 commits May 6, 2024 08:26
@ap0nia
feat: basic setup for login dialog
f38b852
@ap0nia
feat: request handler for username logging in and loading schedule
cabe8ab
@ap0nia
fix: include credentials in fetch request options
4462a07
@ap0nia
feat: enable credentials cors backend
9707394
@ap0nia
chore: fix pnpm lock
1095141
@ap0nia
feat: login with google sends request
e87b369
@ap0nia
feat: load button mvp
2a86dbc
@ap0nia
style(svelte-query): cleanup hooks order
c185ae9
@ap0nia
style: guard clauses and await
462b8c8
@ap0nia
feat(antalmanac): responsive login/logout buttons
3badd46
@ap0nia
feat(antalmanac): working account button
926cd74
@ap0nia
feat(antalmanac): account button settings set username
236fbeb
@ap0nia
feat(backend): always create user when logging in
00b48c0
@ap0nia
feat(antalamanc): login will save user
44b11fb
@ap0nia
feat(antalamanc): load and save interfaces
bea498b
@ap0nia
feat(antalmanac): access controls for saving
f77f03f
@ap0nia
feat(antalamanc): save button with visibility specified
d5d5f7c
@ap0nia
feat(antalmanac): save and load schedules with respect to visibility
e460ca9
@ap0nia
Merge branch 'main' into auth-final
e8f1905
@github-actions github-actions bot requested a review from MinhxNguyen7 May 20, 2024 19:12
@MinhxNguyen7
Copy link
Member

MinhxNguyen7 commented May 20, 2024 •
edited
Loading

Is this done? Also, what do you mean by "excludes DB"? Do you mean it's already been implemented?

Also, can you specify what you expect to/not to work so that I can check it?

@github-actions github-actions bot added the Stale label Jun 20, 2024
@github-actions github-actions bot removed the Stale label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MinhxNguyen7 MinhxNguyen7 Awaiting requested review from MinhxNguyen7

At least 1 approving review is required to merge this pull request.

Assignees

@ap0nia ap0nia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ap0nia @MinhxNguyen7