Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: guest availability saving #110

Merged
merged 10 commits into from
May 31, 2024
Merged

fix: guest availability saving #110

merged 10 commits into from
May 31, 2024

Conversation

KevinWu098
Copy link
Member

@KevinWu098 KevinWu098 commented May 28, 2024 •
edited
Loading

Summary

  1. Guests can now save their availabilities again
  2. Corrects schema and updates functions that depend on changed tables from prior PRs (availabilities, meeting_dates)

Demo

chrome-capture-2024-4-28
Above gif demonstrates saving as a guest, then correct data fetching on refresh when we hardcode in the guest username ("dog").

@KevinWu098 KevinWu098 temporarily deployed to staging-110 May 28, 2024 01:47 — with GitHub Actions Inactive
@KevinWu098 KevinWu098 temporarily deployed to staging-110 May 28, 2024 08:05 — with GitHub Actions Inactive
@KevinWu098 KevinWu098 temporarily deployed to staging-110 May 28, 2024 08:29 — with GitHub Actions Inactive
@KevinWu098 KevinWu098 temporarily deployed to staging-110 May 28, 2024 08:30 — with GitHub Actions Inactive
@KevinWu098 KevinWu098 marked this pull request as ready for review May 28, 2024 08:35
@KevinWu098 KevinWu098 temporarily deployed to staging-110 May 28, 2024 20:36 — with GitHub Actions Inactive
seancfong
seancfong approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@seancfong seancfong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and works on my end.

@seancfong seancfong merged commit fb1c5eb into main May 31, 2024
1 check passed
@seancfong seancfong deleted the kw/108-fix-guest-availability branch May 31, 2024 20:06
@seancfong seancfong linked an issue May 31, 2024 that may be closed by this pull request
Guests cannot save availability #108
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seancfong seancfong seancfong approved these changes

@MinhxNguyen7 MinhxNguyen7 Awaiting requested review from MinhxNguyen7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Guests cannot save availability
2 participants
@KevinWu098 @seancfong