Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Fullstack Login #16

Merged
merged 12 commits into from
Feb 1, 2024
Merged

feat: Fullstack Login #16

merged 12 commits into from
Feb 1, 2024

Conversation

KevinWu098
Copy link
Member

@KevinWu098 KevinWu098 commented Jan 18, 2024 •
edited
Loading

Currently working off of this: https://github.com/delay/sveltekit-auth-starter (it's bar for bar what we need)

Screenshot 2024-01-18 at 12 28 50 PM

Closes #4 #5

@KevinWu098 KevinWu098 temporarily deployed to staging-16 January 18, 2024 11:32 — with GitHub Actions Inactive
@KevinWu098 KevinWu098 marked this pull request as draft January 25, 2024 19:07
@KevinWu098 KevinWu098 temporarily deployed to staging-16 January 25, 2024 21:02 — with GitHub Actions Inactive
@KevinWu098 KevinWu098 marked this pull request as ready for review January 25, 2024 21:18
@KevinWu098 KevinWu098 temporarily deployed to staging-16 January 25, 2024 23:55 — with GitHub Actions Inactive
@KevinWu098 KevinWu098 temporarily deployed to staging-16 January 26, 2024 00:17 — with GitHub Actions Inactive
@KevinWu098 KevinWu098 temporarily deployed to staging-16 January 26, 2024 00:27 — with GitHub Actions Inactive
@KevinWu098 KevinWu098 marked this pull request as draft January 26, 2024 00:39
@MinhxNguyen7
Copy link
Member

Try to merge this soon, before you implement Google Auth.

@KevinWu098 KevinWu098 temporarily deployed to staging-16 January 26, 2024 08:27 — with GitHub Actions Inactive
@KevinWu098 KevinWu098 temporarily deployed to staging-16 January 26, 2024 08:29 — with GitHub Actions Inactive
@KevinWu098 KevinWu098 marked this pull request as ready for review January 26, 2024 08:29
@KevinWu098
Copy link
Member Author

Try to merge this soon, before you implement Google Auth.

@MinhxNguyen7, PR should be good to merge now.

@MinhxNguyen7
Copy link
Member

I'm getting this error when trying to create a user.

image

@KevinWu098
Copy link
Member Author

I'm getting this error when trying to create a user.

image

Looking into it; my guess is that I messed up something by changing the Prisma schema

@KevinWu098 KevinWu098 temporarily deployed to staging-16 January 31, 2024 23:59 — with GitHub Actions Inactive
@KevinWu098 KevinWu098 temporarily deployed to staging-16 February 1, 2024 00:24 — with GitHub Actions Inactive
MinhxNguyen7
MinhxNguyen7 approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@MinhxNguyen7 MinhxNguyen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've got a few things that I'd like to change, but I'll put them in separate issues.

@MinhxNguyen7 MinhxNguyen7 merged commit a37d07b into main Feb 1, 2024
2 checks passed
@MinhxNguyen7 MinhxNguyen7 self-requested a review February 1, 2024 05:45
@MinhxNguyen7 MinhxNguyen7 mentioned this pull request Feb 21, 2024
Closed
@KevinWu098 KevinWu098 deleted the login branch October 17, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MinhxNguyen7 MinhxNguyen7 Awaiting requested review from MinhxNguyen7

Assignees

@KevinWu098 KevinWu098

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get some login system working
2 participants
@KevinWu098 @MinhxNguyen7