feat: ✨ implement google oauth #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinhxNguyen7
reviewed
Feb 8, 2024
Comment on lines
+13
to
+15
| if (dbUser) { | ||
| return dbUser; | ||
| } |
There was a problem hiding this comment.
This should be outside of the try block
There was a problem hiding this comment.
This is a weird... quirk of Lucia (?) where auth.getUser() raises an error when passed a key not in the database.
The try block allows for a "quiet" handling of the not found case. I've attempted to find an alternate solution, but this piece of code isn't particularly offensive to me.
I can hunt down an alternate solution if you'd pref.
MinhxNguyen7
reviewed
Feb 8, 2024
MinhxNguyen7
requested changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
emailproperty of aGoogleUseras the userId.Testing
Since I'm using my personal Google OAuth keys, please test locally:
Current list of tester accounts:
envkeys:#zotmeet-internalon DiscordProcess
Working off a variety of resources with varying efficacies:
Issues
Closes #23
To-Do