Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: user, group basic endpoints #36

Closed
wants to merge 12 commits into from

Conversation

KevinWu098
Copy link
Member

@KevinWu098 KevinWu098 commented Feb 8, 2024

Summary

  1. Likely broken post-merge w/ feat: prisma schema #37
  2. Working with: https://www.youtube.com/watch?v=UMpKaZy0Rpc, https://www.youtube.com/watch?v=UBURTj20HXI, https://www.youtube.com/watch?v=E9J2VXd-bzE

Endpoints

User Endpoints:

  • Get User: GET /profile
  • Update User: PUT /profile?/updateUser
  • Delete User: DELETE /profile?/deleteUser

✅ Group Endpoints:

  • Create Group: POST /groups
  • Get Group by ID: GET /groups/:id
  • Update Group: PUT /groups/:id
  • Delete Group: DELETE /groups/:id
  • List Groups: GET /groups
  • Create meeting in Group: POST /groups/:id?/createMeeting

To-Dos

  • Better endpoint specifications
  • Handle page reload/race condition
  • Conform endpoints to match soon-to-be-updated schemas

Issues

Closes #33

@KevinWu098 KevinWu098 temporarily deployed to staging-36 February 8, 2024 02:09 — with GitHub Actions Inactive
@KevinWu098 KevinWu098 temporarily deployed to staging-36 February 8, 2024 18:59 — with GitHub Actions Inactive
@MinhxNguyen7
Copy link
Member

To note, we don't need to start with this many endpoints. ChatGPT gave you stuff that isn't necessary. There's no reason to have an endpoint that lists all of the users, groups, or meetings. We might query that in the backend, but never from the frontend.

Also, can you add at least one test to each endpoint before implementing it? I know it's a bit annoying, but it'll serve as specification and documentation.

@KevinWu098 KevinWu098 temporarily deployed to staging-36 February 8, 2024 23:34 — with GitHub Actions Inactive
* feat: ✨ [SEMI-STABLE] implement google oauth

* chore: 🔧 cleanup code

* feat: ✨ use sub prop for id

* style: 🎨 move google button to layout

* fix: 🐛 handle empty name fields

* chore: 🔧 [STABLE] remove unused deps

* chore: 🔧 remove unused fields

* feat: ✨ use email as userId

* fix: 🐛 add console log to try block
@KevinWu098 KevinWu098 changed the title feat: backend specs feat: user, group endpoints Feb 9, 2024
@KevinWu098 KevinWu098 changed the title feat: user, group endpoints feat: user, group base endpoints Feb 9, 2024
@KevinWu098 KevinWu098 changed the title feat: user, group base endpoints feat: user, group basic endpoints Feb 9, 2024
@KevinWu098 KevinWu098 temporarily deployed to staging-36 February 9, 2024 00:56 — with GitHub Actions Inactive
@KevinWu098 KevinWu098 temporarily deployed to staging-36 February 9, 2024 00:57 — with GitHub Actions Inactive
HoussinSa and others added 2 commits February 11, 2024 00:38
* feat: prisma schema

* udpate schema

* feat: add back config

* feat: add back key table

* feat: reorder tables

* feat: last missing params added
@KevinWu098 KevinWu098 temporarily deployed to staging-36 February 11, 2024 08:45 — with GitHub Actions Inactive
@KevinWu098 KevinWu098 temporarily deployed to staging-36 February 16, 2024 00:52 — with GitHub Actions Inactive
@KevinWu098
Copy link
Member Author

Have to fix Groups endpoint to match new schema, but not too extensive. Should be doable -- but at a later time

@MinhxNguyen7
Copy link
Member

I'll close this for now since I assume you're not going to be working off of this @KevinWu098

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants