Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setup daisy, tailwind configs #43

Merged
merged 8 commits into from
Feb 12, 2024
Merged

Conversation

KevinWu098
Copy link
Member

Summary

  1. Adds DaisyUI
  2. Enabled Daisy's Emerald theme, according to the Figma specs
  3. Added explicit tailwind colors for gray/slate, such as gray-dark or slate-base
  4. Skeleton is disabled, not deleted
  5. Adds a playground route, for fiddling with components (can remove in final commit)

Screenshots

Screenshot 2024-02-09 at 2 10 55 AM Screenshot 2024-02-09 at 2 11 18 AM

Things to note:

  1. The theme (emerald) matches up (cards look the same), indicating that the theme is indeed being applied
  2. The input's background is of bg-slate-base, indicating the palette is indeed working

@KevinWu098 KevinWu098 temporarily deployed to staging-43 February 9, 2024 10:12 — with GitHub Actions Inactive
@KevinWu098 KevinWu098 temporarily deployed to staging-43 February 11, 2024 19:53 — with GitHub Actions Inactive
Copy link
Member

@MinhxNguyen7 MinhxNguyen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, and everything seems to be working, but I have minor reservations about the greenness.

I think the blue and green should be switched, to be consistent with other ICSSC projects, unless that makes the translation from Figma more laborious, then we can just agree not to use the primary color for cards and buttons.

@KevinWu098 KevinWu098 temporarily deployed to staging-43 February 11, 2024 22:31 — with GitHub Actions Inactive
@KevinWu098 KevinWu098 mentioned this pull request Feb 12, 2024
6 tasks
Copy link
Member

@MinhxNguyen7 MinhxNguyen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry it took a while

@MinhxNguyen7 MinhxNguyen7 merged commit 4091184 into main Feb 12, 2024
2 checks passed
@KevinWu098 KevinWu098 deleted the kw/41-daisy-tailwind-config branch October 17, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants