Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB Deployment Scripts and Variables #86

Merged
merged 5 commits into from
Apr 22, 2024
Merged

DB Deployment Scripts and Variables #86

merged 5 commits into from
Apr 22, 2024

Conversation

MinhxNguyen7
Copy link
Member

@MinhxNguyen7 MinhxNguyen7 commented Apr 21, 2024

Description

  • Add scripts to add migration step to deployment.
  • Add DB connection strings for staging and prod to GitHub Actions, corresponding to Actions Secrets.
  • Additionally, we had to create zotmeet-prod and zotmeet-staging users with relevant permissions to do the migrations. More info coming in Document DB Deployment/Migrations Troubleshooting #87

Testing

  • See that the staging deployment on this PR works.
    • The only existing functionality that uses the DB is signing in. We can see that we get a Postgres error that indicates that at least we are capable of accessing and inserting into the DB.
  • See that the prod deployment works after merging.

Issues

Future Follow-Up

@MinhxNguyen7 MinhxNguyen7 self-assigned this Apr 21, 2024
@MinhxNguyen7 MinhxNguyen7 temporarily deployed to staging-86 April 21, 2024 00:45 — with GitHub Actions Inactive
@MinhxNguyen7 MinhxNguyen7 temporarily deployed to staging-86 April 21, 2024 01:15 — with GitHub Actions Inactive
@MinhxNguyen7 MinhxNguyen7 changed the title DB Deployments DB Deployment Scripts and Variables Apr 21, 2024
@MinhxNguyen7 MinhxNguyen7 requested a review from seancfong April 21, 2024 22:17
Copy link
Member

@seancfong seancfong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seancfong seancfong merged commit 2e7a2f4 into main Apr 22, 2024
1 of 2 checks passed
@seancfong seancfong deleted the db-deploy branch April 22, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev/Prod DBs and environment variables for deployment
2 participants