Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ create summary page #9

Merged
merged 29 commits into from
Dec 23, 2023
Merged

feat: ✨ create summary page #9

merged 29 commits into from
Dec 23, 2023

Conversation

KevinWu098
Copy link
Member

@KevinWu098 KevinWu098 commented Dec 10, 2023

Summary

  • Horizontal scrollable cards with groups
  • Vertical meeting cards in two tabs: Scheduled, Unscheduled
    • Scheduled Meetings are grouped by date and have an "attending status" radio group
    • Unscheduled Meetings are grouped by start date
  • Adds unplugin-icons, as our icon set provider -- I'm using Material Symbols

Desktop:
Screenshot 2023-12-20 at 4 52 09 AM

Mobile:
Screenshot 2023-12-20 at 4 56 06 AM

Issues

Closes #6

Future Followup

  1. Shot myself in the foot a bit with how I implemented Group cards, but background images have no separate opacity from text, so that's something I'd like to fix when we delve into Groups more
  2. Alert Icons

@KevinWu098 KevinWu098 temporarily deployed to staging-9 December 10, 2023 22:58 — with GitHub Actions Inactive
@KevinWu098
Copy link
Member Author

P.S. I am wondering about what icon library / options are available for SvelteKit, since I didn't see any built into Skeleton

@ap0nia
Copy link

ap0nia commented Dec 11, 2023

unplugin-icons with the @iconify/json icon set if you just want access to all of the icons on this site

@KevinWu098
Copy link
Member Author

Screenshot 2023-12-12 at 12 17 42 PM

Current draft; still experimenting with doing a two-tab view for scheduled v. unscheduled, how to handle recurring meetings etc

@MinhxNguyen7
Copy link
Member

P.S. I am wondering about what icon library / options are available for SvelteKit, since I didn't see any built into Skeleton

@ap0nia's seems fine. I don't have an opinion, so do what you think is good @KevinWu098.

Also, next time, if you're looking for a reply from me, tag me. I don't just go through every PR's comments regularly lol.

@KevinWu098
Copy link
Member Author

P.S. I am wondering about what icon library / options are available for SvelteKit, since I didn't see any built into Skeleton

@ap0nia's seems fine. I don't have an opinion, so do what you think is good @KevinWu098.

Also, next time, if you're looking for a reply from me, tag me. I don't just go through every PR's comments regularly lol.

Haha will do; I didn't want to tag ya during finals week, since an icon set wasn't too pressing

@MinhxNguyen7
Copy link
Member

Thanks for the consideration, but just tag me 👍. If I'm busy, I'll leave it for later.

@KevinWu098 KevinWu098 temporarily deployed to staging-9 December 20, 2023 10:18 — with GitHub Actions Inactive
@KevinWu098
Copy link
Member Author

Screenshot 2023-12-20 at 2 17 54 AM

Current iteration:

  1. Added in an "attendance" button, similar to how Google Calendar/Gmail does it
  2. Added in the location as a field

In progress work:

  1. Two tabs for scheduled vs unscheduled
  2. Handle dead space on wider screens
Screenshot 2023-12-20 at 2 19 50 AM

@KevinWu098 KevinWu098 temporarily deployed to staging-9 December 20, 2023 12:51 — with GitHub Actions Inactive
@KevinWu098 KevinWu098 marked this pull request as ready for review December 20, 2023 12:56
@KevinWu098 KevinWu098 changed the title feat: ✨ create summary page (WIP) feat: ✨ create summary page Dec 20, 2023
Copy link
Member

@MinhxNguyen7 MinhxNguyen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! There are just a few things to be ironed out, in addition to the comments:

  • Instead of clicking on the card taking you to the meeting page, I think only the meeting name should do that. It's too easy to fat-finger right now, I'd say. Also, we might want the location to link to something in the future.
  • On mobile, the meeting card stays highlighted after toggling attendance. The previous point would fix this I'd assume.
  • The Scheduled/Unscheduled tabs are misplaced on desktop. Desktop is not a priority, but this should be an easy fix.
  • Similarly, the groups carousel should display a small side scrollbar on desktop.

Also, for easier integration, can you create a store for the meetings and groups and inject the boilerplate from there?

All in all, good work!

src/routes/summary/+page.svelte Outdated Show resolved Hide resolved
src/routes/summary/+page.svelte Outdated Show resolved Hide resolved
src/lib/components/summary/GroupList.svelte Outdated Show resolved Hide resolved
@KevinWu098
Copy link
Member Author

This looks great! There are just a few things to be ironed out, in addition to the comments:

  • Instead of clicking on the card taking you to the meeting page, I think only the meeting name should do that. It's too easy to fat-finger right now, I'd say. Also, we might want the location to link to something in the future.
  • On mobile, the meeting card stays highlighted after toggling attendance. The previous point would fix this I'd assume.
  • The Scheduled/Unscheduled tabs are misplaced on desktop. Desktop is not a priority, but this should be an easy fix.
  • Similarly, the groups carousel should display a small side scrollbar on desktop.

Also, for easier integration, can you create a store for the meetings and groups and inject the boilerplate from there?

All in all, good work!

Aye aye, will do!

@MinhxNguyen7
Copy link
Member

@KevinWu098 Although I did say that we should communicate frequently, you don't need to say that you'll address review comments lol. Thanks for the enthusiasm though.

@KevinWu098 KevinWu098 temporarily deployed to staging-9 December 22, 2023 07:22 — with GitHub Actions Inactive
@KevinWu098 KevinWu098 temporarily deployed to staging-9 December 22, 2023 07:57 — with GitHub Actions Inactive
@KevinWu098 KevinWu098 temporarily deployed to staging-9 December 22, 2023 07:59 — with GitHub Actions Inactive
Copy link
Member

@MinhxNguyen7 MinhxNguyen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

        _    _
     __|_|__|_|__
   _|____________|__
  |o o o o o o o o / 
~'`~'`~'`~'`~'`~'`~'`~

@MinhxNguyen7 MinhxNguyen7 merged commit 3c35cfc into main Dec 23, 2023
2 checks passed
@MinhxNguyen7 MinhxNguyen7 deleted the 6-summary-page branch December 23, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Summary page
3 participants