Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: init pipeline #69

Merged
merged 4 commits into from
Jan 9, 2025
Merged

ci: init pipeline #69

merged 4 commits into from
Jan 9, 2025

Conversation

ecxyzzy
Copy link
Member

@ecxyzzy ecxyzzy commented Jan 9, 2025

Description

Initial version of the CI pipeline, long overdue.

Related Issue

Closes #26.

How Has This Been Tested?

GitHub reads actions workflows from main so cannot be tested yet. Should merge this first then iron out any issues that manifest on other PRs when enabled.

Just kidding, it works somehow? Let's see if things break.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code involves a change to the database schema.
  • My code requires a change to the documentation.

@ecxyzzy ecxyzzy requested a review from andrew-wang0 January 9, 2025 00:29
@ecxyzzy ecxyzzy temporarily deployed to staging-69 January 9, 2025 00:29 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-69 January 9, 2025 00:30 — with GitHub Actions Inactive
@laggycomputer
Copy link
Member

nice

@ecxyzzy
Copy link
Member Author

ecxyzzy commented Jan 9, 2025

tbh it would help if I set up the secrets but it is what it is

@ecxyzzy ecxyzzy temporarily deployed to staging-69 January 9, 2025 00:34 — with GitHub Actions Inactive
@ecxyzzy
Copy link
Member Author

ecxyzzy commented Jan 9, 2025

Confirmed that the deploy works - going to close this PR rq to test the delete workflow

@ecxyzzy ecxyzzy closed this Jan 9, 2025
@ecxyzzy ecxyzzy reopened this Jan 9, 2025
@ecxyzzy ecxyzzy temporarily deployed to staging-69 January 9, 2025 00:41 — with GitHub Actions Inactive
@ecxyzzy
Copy link
Member Author

ecxyzzy commented Jan 9, 2025

Confirmed delete workflow works 🎉

cc: @andrew-wang0

Copy link
Member

@andrew-wang0 andrew-wang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Epic DevOps!

It looks like I'm running into issues when using the endpoints, but we can stash that as future work

@ecxyzzy ecxyzzy temporarily deployed to staging-69 January 9, 2025 00:59 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-69 January 9, 2025 00:59 — with GitHub Actions Inactive
@ecxyzzy
Copy link
Member Author

ecxyzzy commented Jan 9, 2025

Just investigated and it looks like the bindings aren't being created properly. This should hopefully work.

@ecxyzzy
Copy link
Member Author

ecxyzzy commented Jan 9, 2025

@andrew-wang0 would you mind checking a couple of the endpoints again?

@andrew-wang0
Copy link
Member

Looks good now 😎 👍

@ecxyzzy ecxyzzy merged commit 97dfe8e into main Jan 9, 2025
1 check passed
@ecxyzzy ecxyzzy deleted the ci-cd branch January 9, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Pipeline
3 participants