Skip to content

Commit

Permalink
fix: 🐛 messages added on individual pages
Browse files Browse the repository at this point in the history
  • Loading branch information
andy-phu authored and alexanderl19 committed Feb 20, 2024
1 parent bd3aa7c commit 62a202f
Show file tree
Hide file tree
Showing 4 changed files with 30 additions and 9 deletions.
9 changes: 0 additions & 9 deletions src/lib/components/Selector.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@
<ChevronsUpDown size="16" />
</div>
<span class="sr-only">Open Popover</span>
<noscript class="no-js">MUST ENABLE JAVASCRIPT</noscript>
</button>

{#if $open}
Expand Down Expand Up @@ -103,12 +102,4 @@
border: 1px solid var(--gray100);
background-color: var(--background);
}
.no-js {
color: red;
padding-left: 34px;
font-weight: bold;
font-size: 20px;
letter-spacing: 6px;
}
</style>
10 changes: 10 additions & 0 deletions src/routes/(auth)/signin/+page.svelte
Original file line number Diff line number Diff line change
@@ -1 +1,11 @@
<a href="/signin/google">Sign in with Google</a>
<noscript>This Application Requires JS to Work</noscript>

<style>
noscript {
color: red;
padding-left: 34px;
font-weight: bold;
font-size: 20px;
}
</style>
12 changes: 12 additions & 0 deletions src/routes/(nav)/[[selectedMember]]/Table.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,11 @@
{/each}
</tr>
{/each}
<noscript>
<tr>
<td class="no-js"> This Application Requires JS to Work </td>
</tr>
</noscript>
<LineTableRow loading={$contactsQuery.isLoading} />
</thead>
<tbody>
Expand Down Expand Up @@ -242,6 +247,13 @@
}
}
.no-js {
color: red;
padding-left: 16px;
font-weight: bold;
font-size: 20px;
}
td {
$border: 0.75px solid var(--gray100);
border-left: $border;
Expand Down
8 changes: 8 additions & 0 deletions src/routes/(nav)/dashboard/+page.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@

<main>
<h1>Hello, {data.name}</h1>
<noscript>This Application Requires JS to Work </noscript>
<div class="header">
<h2>Members</h2>
<div class="counts">
Expand Down Expand Up @@ -162,4 +163,11 @@
margin: 12px 16px;
gap: 12px;
}
noscript {
color: red;
padding-left: 16px;
font-weight: bold;
font-size: 20px;
}
</style>

0 comments on commit 62a202f

Please sign in to comment.