Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

refactor: ♻️ quick config fix #101

Merged
merged 7 commits into from
Oct 16, 2023
Merged

Conversation

ap0nia
Copy link
Contributor

@ap0nia ap0nia commented Oct 15, 2023

Summary

  • I have my env at the project root, so I'd like dotenv to just load that one for me when I happen to be in the apps/api directory
  • Ideally, the built routes in the temporary .bronya directory don't actually need to include prisma because the dev server can find prisma just fine since it defaults to node_modules which exists locally. This speeds up the dev build because we don't have to manipulate any files before starting up. Also, I encountered some issues with "binary for ARM64" not found, which seemed to be mitigated when no copying takes place (because node_modules is a more reliable place to find prisma)

Followup

  • I think it would definitely be nice if the config file supported top-level await. Since I got tired of maintaining my custom JIT compiler, I switched back to JITI -- which actually happens working on this feature 👀

@ap0nia ap0nia added the no deploy Do not deploy this pull request to staging label Oct 15, 2023
@ap0nia ap0nia changed the base branch from main to fourmilier October 15, 2023 13:25
@ap0nia ap0nia requested a review from ecxyzzy October 15, 2023 13:25
@github-actions github-actions bot changed the title refactor: quick config fix refactor: ♻️ quick config fix Oct 15, 2023
@ecxyzzy ecxyzzy removed the no deploy Do not deploy this pull request to staging label Oct 16, 2023
@ecxyzzy ecxyzzy temporarily deployed to staging-101-docs October 16, 2023 04:02 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-101 October 16, 2023 04:02 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-101 October 16, 2023 04:43 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-101-docs October 16, 2023 04:43 — with GitHub Actions Inactive
Copy link
Member

@ecxyzzy ecxyzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ecxyzzy ecxyzzy merged commit 4758dd8 into fourmilier Oct 16, 2023
@ecxyzzy ecxyzzy deleted the fourmilier-config-fix branch October 16, 2023 05:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants