Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

perf: ⚡️ optimize courses/instructors by ID #117

Merged
merged 18 commits into from
Dec 21, 2023
Merged

perf: ⚡️ optimize courses/instructors by ID #117

merged 18 commits into from
Dec 21, 2023

Conversation

ecxyzzy
Copy link
Member

@ecxyzzy ecxyzzy commented Dec 10, 2023

No description provided.

@ecxyzzy ecxyzzy temporarily deployed to staging-117-docs December 10, 2023 00:54 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-117 December 10, 2023 00:54 — with GitHub Actions Inactive
@github-actions github-actions bot changed the title perf: optimize courses/instructors by ID (WIP) perf: ⚡️ optimize courses/instructors by ID (WIP) Dec 10, 2023
@ecxyzzy ecxyzzy temporarily deployed to staging-117-docs December 10, 2023 01:14 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-117 December 10, 2023 01:14 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-117-docs December 10, 2023 01:16 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-117 December 10, 2023 01:16 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-117 December 10, 2023 01:26 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-117-docs December 10, 2023 01:26 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-117 December 10, 2023 02:03 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-117-docs December 10, 2023 02:03 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-117-docs December 10, 2023 02:05 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-117 December 10, 2023 02:05 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-117 December 10, 2023 02:17 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-117-docs December 10, 2023 02:17 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-117 December 18, 2023 08:12 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-117-docs December 18, 2023 08:12 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-117-docs December 18, 2023 08:23 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-117 December 18, 2023 08:23 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-117 December 19, 2023 01:28 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-117-docs December 19, 2023 01:28 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-117-docs December 19, 2023 01:46 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-117 December 19, 2023 01:46 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy marked this pull request as ready for review December 21, 2023 04:03
@ecxyzzy ecxyzzy changed the title perf: ⚡️ optimize courses/instructors by ID (WIP) perf: ⚡️ optimize courses/instructors by ID Dec 21, 2023
@ecxyzzy ecxyzzy requested a review from ap0nia December 21, 2023 04:15
ap0nia
ap0nia approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@ap0nia ap0nia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think everything looks solid 💪

I just left styling remarks.

apps/api/bronya.config.ts Show resolved Hide resolved
apps/api/src/global.d.ts Outdated Show resolved Hide resolved
apps/api/src/lib/utils.ts Outdated Show resolved Hide resolved
@ecxyzzy ecxyzzy temporarily deployed to staging-117-docs December 21, 2023 13:00 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy temporarily deployed to staging-117 December 21, 2023 13:00 — with GitHub Actions Inactive
@ecxyzzy ecxyzzy merged commit ffe387c into main Dec 21, 2023
5 checks passed
@ecxyzzy ecxyzzy deleted the build-optimization branch December 21, 2023 13:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ap0nia ap0nia ap0nia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ecxyzzy @ap0nia