This repository has been archived by the owner on Oct 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: ✨ implement degreeworks scraper and requirements endpoint #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use static async factories for the DegreeWorks and PPAPI clients. This prevents logging weirdness and also ensures that all required fields are actually initialized before instance methods are called. - Encapsulate all audit-related functions into an AuditParser class. Like the other clients this also uses a static async factory, since it requires the PPAPI client to normalize course numbers.
github-actions
bot
changed the title
feat: implement degreeworks scraper and requirements endpoint
feat: ✨ implement degreeworks scraper and requirements endpoint
Mar 9, 2024
ap0nia
suggested changes
May 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a lot of stuff, and most of it looks reasonable. Some adjustments/clean up would be good 👍
ap0nia
approved these changes
May 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add the DegreeWorks scraper and relevant REST endpoints/GraphQL queries for fetching the data.
Endpoints
/v1/rest/degrees/all
(allDegrees
): Get all degree types as a top-level object, including its ID, dotted abbreviation, and all programs offered under that degree./v1/rest/degree/majors
(major
/majors
): Get one degree by its ID, or all degrees that fulfill some criteria. Currently supported filters are degree ID (e.g.BS
) and/or case-insensitive name substring./v1/rest/degree/minors
(minor
/minors
): Get one minor by its ID, or all minors by case-insensitive substring./v1/rest/degree/specializations
(specialization
/specializations
/specializationsByMajorId
): Get one specialization by its ID, or all specializations by case-insensitive substring, or all specializations for a major's ID.Issues
Closes #137.