Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show empty prerequisite box #356

Closed
js0mmer opened this issue Sep 21, 2023 · 0 comments · Fixed by #367
Closed

Don't show empty prerequisite box #356

js0mmer opened this issue Sep 21, 2023 · 0 comments · Fixed by #367
Assignees
@kylerpan
Labels
good first task Good for newcomers Story Point: 2 small UI change, maybe some CSS + JS. unit test would ideally be written, but not always.

Comments

@js0mmer
Copy link
Member

js0mmer commented Sep 21, 2023

An empty box is shown at the bottom where there would normally be prerequisites listed in text as they are in the catalogue. For courses without prerequisites, the box is empty. Let's change it so the box is hidden if there are no prerequisites.

image
@js0mmer js0mmer added the Story Point: 2 small UI change, maybe some CSS + JS. unit test would ideally be written, but not always. label Sep 21, 2023
@js0mmer js0mmer moved this to Backlog in PeterPortal Client Sep 21, 2023
@js0mmer js0mmer added the good first task Good for newcomers label Oct 9, 2023
@kylerpan kylerpan self-assigned this Oct 17, 2023
@kylerpan kylerpan mentioned this issue Oct 17, 2023
Merged
5 tasks
@js0mmer js0mmer linked a pull request Oct 18, 2023 that will close this issue
Fixed prereq box to only appear when there is text #367
Merged
5 tasks
@js0mmer js0mmer moved this from Backlog to In Review in PeterPortal Client Oct 18, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in PeterPortal Client Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylerpan kylerpan

Labels
good first task Good for newcomers Story Point: 2 small UI change, maybe some CSS + JS. unit test would ideally be written, but not always.
Projects
PeterPortal Client
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed prereq box to only appear when there is text icssc/peterportal-client
2 participants
@js0mmer @kylerpan