Fixed prereq box to only appear when there is text #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed staging instance to https://staging-367.peterportal.org |
ecxyzzy
pushed a commit
that referenced
this pull request
Dec 4, 2023
js0mmer
added a commit
that referenced
this pull request
Jan 21, 2024
* feat: initial migrate test * feat: stable ground (no more ts errors) * feat: everything works(?) * fix: update footer * feat: more cleanup * fix: properly case GitHub * fix: sort grade dist quarter dropdown, misc fixes * fix: use async because it is almost 2024 * fix: address most comment changes * fix: show class title in prereq tree nodes, correct links * fix: less bad solution for prereq titles * feat: fetch course/instructor data on demand * fixed prereq box to only appear when there is text (#367) * fix: grab review form fix from #375 Co-authored-by: Jacob Sommer <[email protected]> * feat: use graphql for courses again, set endpoint to staging * chore: migrate to latest api staging * fix: make prereq tree node labels consistently spaced * fix: reincorporate #391 changes * feat: migrate to latest staging, hopefully fix perf issues * Fix review form merging * Restore original transformation fucntions * Restore API url env vars --------- Co-authored-by: Kyle Pan <[email protected]> Co-authored-by: Jacob Sommer <[email protected]> Co-authored-by: Jacob Sommer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for issue #356
Screenshots
Before
After
Steps to verify/test this change:
Final Checks:
(optional)
Issues
Closes #