Updated Build & Deploy Message #298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed staging instance to https://staging-298.peterportal.org Please note that it usually takes a couple minutes for the instance to be deployed and the link above may temporarily display an error message. |
ethanwong16
approved these changes
May 22, 2023
| @@ -109,4 +109,4 @@ jobs: | |||
| with: | |||
| header: staging url | |||
| recreate: true | |||
| message: Deployed staging instance to https://staging-${{ github.event.pull_request.number }}.peterportal.org | |||
| message: Deployed staging instance to https://staging-${{ github.event.pull_request.number }}.peterportal.org Please note that it usually takes a couple minutes for the instance to be deployed and the link above may temporarily display an error message. | |||
There was a problem hiding this comment.
Great work! A minor suggestion, were you able to look into potentially adding a newline between the previous message and the new one you added?
|
Closing for now since it no longer seems to be necessary with our current infrastructure (deploying with SST). Instance seems to be up as soon as the link is commented now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the build and deploy message to display that the request may take a few minutes to process. The message added includes...
"Please note that it usually takes a couple minutes for the instance to be deployed and the link above may temporarily display an error message."