Add review sorting #316
Merged
Add review sorting #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 basic options * Most Recent (Default) * Top Reviews * Controversial
Better practice since it is unique to the element rather then being based on index. Can cause issues with states being mixed up otherwise. See https://react.dev/learn/rendering-lists#keeping-list-items-in-order-with-key
SenghoungLim
suggested changes
Jun 9, 2023
There was a problem hiding this comment.
Everything seems to work well, good job! Just a nitpicking, on a smaller screen like iPhone X, the verification checkbox is a bit clustered from the sorting menu. I suggest we can have a newline separation and align the check box to the sorting box above. Otherwise, everything looks good.
js0mmer
force-pushed
the
jacob/review-sorting
branch
from
211a8de to
4dd9b08
Compare
Good catch. Let me know what you think of it now. |
SenghoungLim
approved these changes
Jun 22, 2023
|
Deployed staging instance to https://staging-316.peterportal.org |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added sorting by most recent, top reviews (highest score), and controversial (lowest score). Also added a checkbox to filter to verified reviews only. Also fixed some react key issues after running into one with the array of subreviews. The key being the index caused data to be mismatched among the reviews when sorting them and changing their order. The new key for each subreview in the array is now the review id. Closes #275.
Screenshots
Steps to verify/test this change:
Final Checks:
(optional)