Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- force render when search index changes #366

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Conversation

MFYLM
Copy link
Contributor

@MFYLM MFYLM commented Oct 17, 2023

Description

Before when users click between professors and courses, it won't trigger necessary API call to retrieve data from backend and there will be a blank page with no information. Now I force the page to render and users could see both pages.

Screenshots

Steps to verify/test this change:

  • Verify changes work as expected on staging instance

Final Checks:

  • Verify successful deployment
  • Delete branch

(optional)

  • Write tests
  • Write documentation

Issues

Closes #305

@MFYLM MFYLM requested review from js0mmer and aahei October 17, 2023 22:48
@js0mmer js0mmer linked an issue Oct 18, 2023 that may be closed by this pull request
Copy link
Member

@js0mmer js0mmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@aahei aahei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Deployed staging instance to https://staging-366.peterportal.org

@MFYLM MFYLM merged commit 4b598ef into master Oct 20, 2023
2 checks passed
@js0mmer js0mmer deleted the fetch-both-professor-course branch November 1, 2023 06:54
@aahei aahei mentioned this pull request Nov 30, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not fetching professor data when user clicks professor tab
3 participants