Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint to backend #404

Merged
merged 19 commits into from
Jan 26, 2024
Merged

Add eslint to backend #404

merged 19 commits into from
Jan 26, 2024

Conversation

js0mmer
Copy link
Member

@js0mmer js0mmer commented Jan 21, 2024

Description

  • Added eslint to the backend
  • Fixed eslint errors
    • Refactored mongo helpers to fix eslint errors
      • could use some more work in the future. switch to mongoose?
    • Fixed types for some express routes/request objects
      • Could use more work. We are inconsistent with our typing and many routes do not have the request typed.
      • Response body isn't typed either.
      • This is something we can take care of when adding tRPC
  • Updated packages
  • Added a lint workflow

Steps to verify/test this change:

  • Verify changes work as expected on staging instance
  • Verify lint workflow works

Final Checks:

  • Verify successful deployment

(optional)

  • Write tests
  • Write documentation

Issues

Closes #400

@js0mmer js0mmer force-pushed the eslint-backend branch 2 times, most recently from 404c975 to 07c4552 Compare January 21, 2024 23:40
@js0mmer js0mmer marked this pull request as ready for review January 21, 2024 23:59
@js0mmer js0mmer self-assigned this Jan 25, 2024
Copy link

Deployed staging instance to https://staging-404.peterportal.org

@js0mmer js0mmer merged commit 7948328 into master Jan 26, 2024
3 checks passed
@js0mmer js0mmer deleted the eslint-backend branch January 26, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add eslint to the backend
1 participant