-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the user to import transcripts into the Roadmap Planner #455
Conversation
Ignoring dependencies array pre-commit hook for now because I want to make sure this doesn't break anything
Currently only works with fall, winter, and spring quarters.
This should make importing transcripts with summer courses work
@js0mmer do you think you could take a look at the files failing the lint check and update the dependency arrays for them? |
Yeah |
…tal-client into import-transcript
Interesting, yours allowed you to commit even with the dependency array warnings, but mine didn't at first |
Yeah, formatting just seemed to be messed up somehow. |
I will leave the pre-existing dependency warnings to be resolved later, don't want to move too much stuff around in this PR that's out of scope. |
yeah it's not giving an error on commit anymore so not going to worry about it |
Going to request review on this once we decide what the behavior of the import should be. It's currently set to override the entire roadmap because it was easier to use the |
Now that #440 is merged, I think this would be a great first feature to add to the changelog modal! |
this will make it pick up community college courses' units since they don't have a score associated with them
Included the changes we discussed yesterday regarding quarters and CC course credits @js0mmer |
This requires removing all spaces to form IDs
Still not a huge fan of just removing spaces but I do agree that it's better than essentially reusing 40 lines of code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Development Notes
Any comments would be very helpful!
Description
Screenshots
Import Dialog with Information (styles and WIP)
Steps to verify/test this change:
Final Checks:
Issues
Closes #443