Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PR template #527

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Update PR template #527

merged 3 commits into from
Dec 9, 2024

Conversation

js0mmer
Copy link
Member

@js0mmer js0mmer commented Dec 7, 2024

Description

  • Update PR template

Steps to verify/test this change:

  • Verify changes work as expected on staging instance

Final Checks:

  • Verify successful deployment

(optional)

  • Write tests
  • Write documentation

Issues

Closes #

@js0mmer js0mmer added the no deploy Do not deploy to staging instance label Dec 7, 2024
@js0mmer js0mmer requested a review from Awesome-E December 7, 2024 00:27
Awesome-E
Awesome-E reviewed Dec 9, 2024
View reviewed changes
Copy link
Member

@Awesome-E Awesome-E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing I think we should still specify

.github/pull_request_template.md Outdated Show resolved Hide resolved
@js0mmer js0mmer requested a review from Awesome-E December 9, 2024 22:17
@js0mmer js0mmer merged commit 68f5e96 into main Dec 9, 2024
2 checks passed
@js0mmer js0mmer deleted the update-pr-template branch December 9, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Awesome-E Awesome-E Awesome-E approved these changes

Assignees
No one assigned
Labels
no deploy Do not deploy to staging instance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@js0mmer @Awesome-E