Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Updated At Date to the Review Card #534

Merged
merged 8 commits into from
Jan 29, 2025
Merged

Add Updated At Date to the Review Card #534

merged 8 commits into from
Jan 29, 2025

Conversation

philosolog
Copy link
Member

@philosolog philosolog commented Dec 7, 2024 •
edited by charlieweinberger
Loading

Description

  • Updates the review card updatedAt attribute in the database
  • Displays the date of the most recent update to a review card, if changed

Preview

updatedAt demo

Steps to verify/test this change:

  • Verify that review card edits correctly update the corresponding updatedAt database entry
  • Verify that the Updated: section on a review correctly displays the database entry

Final Checks:

  • Verify successful deployment

Issues

Closes #511

@philosolog philosolog requested review from js0mmer, timobraz and Awesome-E and removed request for js0mmer December 7, 2024 03:25
@philosolog philosolog temporarily deployed to staging-534 December 7, 2024 03:25 — with GitHub Actions Inactive
@js0mmer js0mmer linked an issue Dec 11, 2024 that may be closed by this pull request
Save/show timestamp of last review edit #511
Closed
@philosolog philosolog temporarily deployed to staging-534 January 13, 2025 16:38 — with GitHub Actions Inactive
Awesome-E
Awesome-E requested changes Jan 13, 2025
View reviewed changes
Copy link
Member

@Awesome-E Awesome-E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I go to edit a review, the review text gets updated immediately upon saving, but I have to reload the page before "Updated at [date]" appears

@Awesome-E
Copy link
Member

Awesome-E commented Jan 13, 2025 •
edited
Loading

when you're ready for re-review, don't forget to click this button as well as the "re-request review" button next to "reviewers"
image
image

@charlieweinberger
Copy link
Contributor

Not sure exactly what the changes are here, but this seems like it'd conflict with my pull request #552, which heavily modifies SubReview.tsx. Just something to keep in mind, although this seems like a minor change that I could easily integrate into my pr.

@philosolog philosolog marked this pull request as ready for review January 28, 2025 18:51
@philosolog philosolog temporarily deployed to staging-534 January 28, 2025 18:52 — with GitHub Actions Inactive
@philosolog philosolog requested a review from Awesome-E January 28, 2025 18:52
@philosolog philosolog temporarily deployed to staging-534 January 28, 2025 18:56 — with GitHub Actions Inactive
Awesome-E
Awesome-E reviewed Jan 28, 2025
View reviewed changes
Copy link
Member

@Awesome-E Awesome-E left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like because of the other changes on the review card, "posted" and "created" are now duplicates, and some other layout stuff happened.

I can take a look at this later

image

@Awesome-E Awesome-E changed the title Update SubReview.tsx Add Updated At Date to the Review Card Jan 28, 2025
@philosolog philosolog temporarily deployed to staging-534 January 28, 2025 19:46 — with GitHub Actions Inactive
@philosolog philosolog requested a review from Awesome-E January 28, 2025 19:47
Awesome-E
Awesome-E reviewed Jan 28, 2025
View reviewed changes
Copy link
Member

@Awesome-E Awesome-E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better now! Only issue is that when I create a new review, it automatically populates the "updated at" now

@philosolog philosolog temporarily deployed to staging-534 January 28, 2025 20:28 — with GitHub Actions Inactive
@philosolog philosolog requested a review from Awesome-E January 28, 2025 20:29
Awesome-E
Awesome-E approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@Awesome-E Awesome-E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

timobraz
timobraz approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@timobraz timobraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Staged instance works as expected

@Awesome-E Awesome-E temporarily deployed to staging-534 January 29, 2025 16:52 — with GitHub Actions Inactive
@Awesome-E
Copy link
Member

I'll merge this one now, but in the future @philosolog you can merge if you get the approvals

@Awesome-E Awesome-E merged commit 6696237 into main Jan 29, 2025
2 checks passed
@Awesome-E Awesome-E deleted the review-updatedAt-display branch January 29, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timobraz timobraz timobraz approved these changes

@Awesome-E Awesome-E Awesome-E approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save/show timestamp of last review edit
4 participants
@philosolog @Awesome-E @charlieweinberger @timobraz