-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restyle transfer credits #536
Open
CadenLee2
wants to merge
9
commits into
main
Choose a base branch
from
restyle-transfer-credits
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to restyle-transfer-credits
…to restyle-transfer-credits merge updated upstream from main
…to restyle-transfer-credits pull changes from main
Awesome-E
reviewed
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good, just a couple things
- See above comment about styling
- You opened the PR but didn't set two reviewers. Make sure to set me as one reviewer and one other individual contributor as a second reviewer.
…to restyle-transfer-credits
Looks a bit better now, but just one more thing to check – is the input font size at least 16px? When I tap the field on iOS, it zooms the entire page, which usually means that the font size is less than that size |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restyle the Transfer Credits modal (under Roadmap page)
Description
ppc-modal
(ex. theedit year
modal)p
smaller when inside atransfer-modal
Screenshots
Steps to verify/test this change:
Final Checks:
(optional)
Issues
Closes #517