Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove axios #539

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Remove axios #539

wants to merge 5 commits into from

Conversation

js0mmer
Copy link
Member

@js0mmer js0mmer commented Dec 9, 2024

Description

  • We use fetch in all but one place for making requests on the backend
  • Converted that from axios to fetch to standardize things and remove a dependency

Test Plan

  • Verify reCAPTCHA for reviews still functions appropriately and succeeds when checked, fails if not checked

@js0mmer js0mmer requested a review from Awesome-E December 9, 2024 22:49
@Awesome-E
Copy link
Member

Now we just have to do this on the frontend
Will review this later when the deployment is up

@js0mmer
Copy link
Member Author

js0mmer commented Dec 9, 2024

Oh interesting, it is installed on the frontend despite not being used there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Awesome-E Awesome-E Awaiting requested review from Awesome-E

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@js0mmer @Awesome-E