Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: vote color updates on verify reviews page #542

Merged
merged 1 commit into from
Dec 18, 2024
Merged

fix: vote color updates on verify reviews page #542

merged 1 commit into from
Dec 18, 2024

Conversation

js0mmer
Copy link
Member

@js0mmer js0mmer commented Dec 11, 2024

Description

  • Refactor the verify reviews page to use the reviews redux slice instead of a component state

Screenshots

before:

before.mp4

after:

after.mp4

Test Plan

  • Go to verify reviews page and try upvoting/downvoting

Issues

Closes #402

@js0mmer js0mmer requested a review from Awesome-E December 11, 2024 23:30
@js0mmer js0mmer temporarily deployed to staging-542 December 11, 2024 23:30 — with GitHub Actions Inactive
Awesome-E
Awesome-E approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@Awesome-E Awesome-E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that this already existed in the slice

@js0mmer
Copy link
Member Author

js0mmer commented Dec 18, 2024

Yeah, the SubReview component implements color updates through updating the slice state.

@js0mmer js0mmer merged commit c4db814 into main Dec 18, 2024
2 checks passed
@js0mmer js0mmer deleted the fix-vote-color-updates branch December 18, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Awesome-E Awesome-E Awesome-E approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vote colors don't update on verify reviews page
2 participants
@js0mmer @Awesome-E