Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use shared requirements loading icon component #613

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Use shared requirements loading icon component #613

merged 1 commit into from
Mar 3, 2025

Conversation

CadenLee2
Copy link
Contributor

Extracted the loading icon found in all requirements lists into a separate component

Description

  • Created the RequirementsLoadingIcon component in the sidebar folder (since it's specific to requirements lists)
  • Replaced the repeated loading icon code in the major, minor, and GE requirements list with this component

Screenshots

Test Plan

  • Ensure the loading icon still works/looks as intended with all the requirements lists

Issues

Closes #593

@CadenLee2 CadenLee2 temporarily deployed to staging-613 February 27, 2025 23:29 — with GitHub Actions Inactive
@CadenLee2 CadenLee2 merged commit d0bb6ff into main Mar 3, 2025
2 checks passed
@CadenLee2 CadenLee2 deleted the shared-loading-icon branch March 3, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Awesome-E Awesome-E Awesome-E approved these changes

@ellisl10 ellisl10 Awaiting requested review from ellisl10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

For degree requirements, use shared loading icon component
2 participants
@CadenLee2 @Awesome-E