Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icub-head compile robotology-superbuild #338

Merged

Conversation

martinaxgloria
Copy link
Member

@martinaxgloria martinaxgloria commented Mar 7, 2024

This PR adds a missing cd build in icub-head robotology-superbuild installation here:

## Compile robotology-superbuild
~~~sh
cd /usr/local/src/robot/robotology-superbuild
mkdir build
cmake -DROBOTOLOGY_USES_GAZEBO:BOOL=OFF -DROBOTOLOGY_ENABLE_ICUB_HEAD:BOOL=ON ..
make

cc @Nicogene

@martinaxgloria martinaxgloria self-assigned this Mar 7, 2024
@martinaxgloria martinaxgloria requested review from pattacini and Nicogene and removed request for traversaro March 7, 2024 08:21
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pattacini pattacini merged commit 1253152 into icub-tech-iit:master Mar 7, 2024
1 check passed
@martinaxgloria martinaxgloria deleted the fix/icub-head-superbuild branch March 7, 2024 08:25
@traversaro
Copy link
Member

traversaro commented Mar 7, 2024

By the way usual OT, but I wanted to write that down. Recently I started using more and the -S -B options of CMake, that have the advantage of automatically creating the build directory. Using those options, the instructions can be simplified to be:

cd /usr/local/src/robot/robotology-superbuild
cmake -S. -Bbuild -DROBOTOLOGY_USES_GAZEBO:BOOL=OFF -DROBOTOLOGY_ENABLE_ICUB_HEAD:BOOL=ON
cmake --build ./build

the nice thing is that with -Bbuild, the build directory is automatically created even it does not exists. I am not saying we should switch to those style (as most users probably they are not familiar with those) but I want to shared this options. Another thing that could help usability (once we drop support for CMake 3.16) is robotology/robotology-superbuild#1615, that would further simplify this to:

cd /usr/local/src/robot/robotology-superbuild
cmake --preset xcub-head
cmake --build ./build

@pattacini
Copy link
Member

I'm also fond of using the options -S -B. Some time ago I switched to those in many tutorials, including the grasping sandbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants