update abbreviation handling #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… assume the abbreviation is at the end of the string
mandd
reviewed
Jan 7, 2025
| if word not in not_acronyms: | ||
| if word in self.abbrDict.keys(): | ||
| full = self.abbrDict[word] | ||
| splitWord = re.split(r'[-\d+]', word) # split word if word contains '-' or numbers |
There was a problem hiding this comment.
should we perform this treatment before the abbreviation handling (in the text pre-processing steps)?
There was a problem hiding this comment.
your are right, fixed.
| if word in self.abbrDict.keys(): | ||
| full = self.abbrDict[word] | ||
| splitWord = re.split(r'[-\d+]', word) # split word if word contains '-' or numbers | ||
| checkAbbr = word if len(splitWord) == 1 else splitWord[-1] |
mandd
requested changes
Feb 26, 2025
| """ | ||
|
|
||
| # | ||
| terms1 = [ |
There was a problem hiding this comment.
you might want to add "before, while, during"
There was a problem hiding this comment.
I have added before and during, not sure about while
| "year", "years" | ||
| ] | ||
|
|
||
| # pattern = [ |
There was a problem hiding this comment.
are we keeping this commented portion for future development?
| ent = Span(doc, startToken, endToken + 1, label="Temporal") | ||
| newEnts.append(ent) | ||
|
|
||
| ## Following is used to add a custom attribute to indicate Temporal |
There was a problem hiding this comment.
yes, I would keep these commented lines.
mandd
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… assume the abbreviation is at the end of the string
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
This PR will update abbreviation handling when number or '-' are combined with the abbreviation and the abbreviation only presented at the end of the combination.
What are the significant changes in functionality due to this change request?
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.