-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not warn about comments that go over the line length #658
Merged
tjlaboss
merged 9 commits into
alpha-test-dev
from
188-do-not-warn-about-comments-that-go-over-the-line-length
Feb 8, 2025
Merged
Do not warn about comments that go over the line length #658
tjlaboss
merged 9 commits into
alpha-test-dev
from
188-do-not-warn-about-comments-that-go-over-the-line-length
Feb 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-go-over-the-line-length
tjlaboss
requested changes
Feb 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, this is a relief. Code changes look good, test looks good, and I can confirm that it works on real models.
A couple minor fixes before merging:
tjlaboss
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
alpha testing
Issues that came up during alpha testing
feature request
An issue that improves the user interface.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist for MontePy
Description
This is probably the most requested feature (whether they say so or not).
LineOverrunWarnings
andLineExpansionWarnings
are no longer created for comments.This does the following:
3. If it's a
c
comment do nothing; do not wrap.4. If it has a
$
comment wrap the uncommented part, and then add the comment to the end.Fixes #188
General Checklist
Documentation Checklist
First-Time Contributor Checklist
pyproject.toml
if you wish to do so.Additional Notes for Reviewers
Ensure that:
📚 Documentation preview 📚: https://montepy--658.org.readthedocs.build/en/658/