Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding AD Curl and Coupled Curl Capability #29869

Open
wants to merge 5 commits into
base: next
Choose a base branch
from

Conversation

csdechant
Copy link

Reason

As the development and implementation of the electromagnetic module increases, there is a need to include the option to defined the curl and coupled curl operators as AD functions. This helps to avoid errors involving more complex formulations that include the curl of variables in lieu of using hand-coded Jacobians.

This closes Issue #29868

Design

A function named adCurlSln() that calculates the curl of a variable as an AD variable was included in the MooseVariableData file. This enables the used of the curl operator on AD variables and coupled AD variables. To ensure that the AD curl operators are working as as intended, tests using type = 'PetscJacobianTester' were added.

Impact

The inclusion of a AD versions of the curl and coupled curl operator will allow for faster development of additional physics into the MOOSE framework that utilizes the curl of variables.

@moosebuild
Copy link
Contributor

Job Precheck, step Clang format on e723faf wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/29869/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format e976a1d94e8dad990e3409a95ae0f030f1b8970f

@cticenhour cticenhour self-assigned this Feb 12, 2025
@cticenhour
Copy link
Member

Setting some time aside tomorrow to look at this. In the meantime, looks like one of your tests is diffing slightly on the Linux targets.

@moosebuild
Copy link
Contributor

Job Documentation, step Docs: sync website on cc4f401 wanted to post the following:

View the site here

This comment will be updated on new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants