Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update language server extension in moose-dev #29874

Open
wants to merge 7 commits into
base: next
Choose a base branch
from
Open

Update language server extension in moose-dev #29874

wants to merge 7 commits into from
+36 −14

Conversation

loganharbour
Copy link
Member

Closes #29873

@loganharbour loganharbour marked this pull request as ready for review February 12, 2025 22:20
@moosebuild
Copy link
Contributor

moosebuild commented Feb 13, 2025 •
edited
Loading

Job Documentation, step Docs: sync website on dc56fd9 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Feb 13, 2025 •
edited
Loading

Job Coverage, step Generate coverage on dc56fd9 wanted to post the following:

Framework coverage

Mutiple base shas were found when retrieving head reports:
e976a1d
b05d63c

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

@loganharbour loganharbour force-pushed the 29873_language_server branch 4 times, most recently from ffc8261 to 434e39c Compare February 14, 2025 17:58
milljm
milljm approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@milljm milljm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lame. But if we must we must!

lame to Yaml I mean, for its type detection stuff

@moosebuild
Copy link
Contributor

Job Coverage, step Verify coverage on dc56fd9 wanted to post the following:

The following coverage requirement(s) failed:

  • Failed to generate framework coverage rate (required: 81.0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milljm milljm milljm approved these changes

@cticenhour cticenhour Awaiting requested review from cticenhour cticenhour is a code owner

@joshuahansel joshuahansel Awaiting requested review from joshuahansel

@lindsayad lindsayad Awaiting requested review from lindsayad

@GiudGiud GiudGiud Awaiting requested review from GiudGiud

@grmnptr grmnptr Awaiting requested review from grmnptr

Assignees

@loganharbour loganharbour

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update language server in moose-dev.def
3 participants
@loganharbour @moosebuild @milljm