-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #338: Added onEvaluatedDataChange prop to expose the result of the formula #379
Conversation
Co-authored-by: Iddan Aaronsohn <[email protected]>
Rename prop function name getEvaluatedData to onEvaluatedDataChange
Please see CI failure. You can also run it locally with |
Adjust space of new changed code
I tried Prettier ESLint It worked. let's try to merge again |
@iddan I have committed code with Prettier that resolved a CI failure issue. Can you please review the code? |
@iddan , I have sent a review request for changes to address the resolved CI failure. Please take a moment to review.Thank you |
Thank you, seems like CI is still failing |
@iddan, I ran npm run check-format in my local code and identified code style issues in 96 files. After running npm run format, I resolved the code style issues in all 96 files. However, I only committed the changes to the Spreadsheet.tsx file , because in CI failure only in Spreadsheet.tsx file code style issue was found. I believe this should resolve the issue. If you have any other suggestions, please let me know |
@iddan After running the 'npm run ci' command locally, I encountered an error. After fixing the above CI failure ( Property 'onEvaluatedDataChange' is missing in type ), should I push the commit that resolved the CI failure? Can you please provide suggestions regarding this below error? May this below error affect to CI ? Error: No files matching the pattern "'*/**.css'" were found. |
@iddan Yes, you are correct. I resolved the code issue in my local system. After that, I ran 'npm run CI' locally, and I encountered an error, as you can see in the screenshot above. I am seeking confirmation from you, and if the above error does not affect the CI failure, then I will commit the new code. I've been facing CI failures repeatedly, so if the mentioned error doesn't impact the CI failure, I'll proceed to commit the new code and try again for a successful merge |
You can push, and if the CI command passes in GitHub Actions it's ok |
Pull Request Test Coverage Report for Build 8166588409Details
💛 - Coveralls |
@iddan Do you need to release a new version to make these changes available to all npm package users? Because added new props visible in storybook and that working but not show in npm package after installation |
Issue #338: Added getEvaluatedData prop to expose the result of the formula