Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ubuntu22_support #227

Merged
merged 44 commits into from
Sep 13, 2023
Merged

ubuntu22_support #227

merged 44 commits into from
Sep 13, 2023

Conversation

chetanyagoyal
Copy link
Collaborator

Copy link
Collaborator

@saicharan0112 saicharan0112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @chetanyagoyal ! A few suggestions...

  1. since the compile script for ngspice is not used by anyone directly, can you please put this inside the .github/docker/conda/scripts same as the xyce_install.sh script location?
  2. I am not really comfortable have running different commands to setup the environment (especially restarting the terminal). Do you think you can pack all the operations with a single command? You can always use Makefile. Try placing them under a single Makefile where you can run make conda and make <next_thing>
  3. I remember you needed sudo privilages to install ngspice and klayout, not sure where the user need to enter the password in this process. Can you elaborate this info in the docs you edited and also it would be really good if you could add snapshots of it?

@chetanyagoyal
Copy link
Collaborator Author

Changes include -

  1. Moving miscellaneous scripts into scripts folder
  2. Creating a wrapper script for easier installation
  3. Enhancing README.rst

README.rst Outdated Show resolved Hide resolved
install_script.sh Outdated Show resolved Hide resolved
.script Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@saicharan0112 saicharan0112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments. I think there is still some work that needs to be done.

@chetanyagoyal chetanyagoyal changed the title ub22_support ubuntu22_support Sep 10, 2023
Copy link
Collaborator

@saicharan0112 saicharan0112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on ubuntu 22. works fine.

dependencies.sh Outdated Show resolved Hide resolved
Final changes to klayout version completed
@msaligane msaligane merged commit 778e40e into idea-fasoc:main Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants