-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ubuntu22_support #227
ubuntu22_support #227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @chetanyagoyal ! A few suggestions...
- since the compile script for ngspice is not used by anyone directly, can you please put this inside the .github/docker/conda/scripts same as the xyce_install.sh script location?
- I am not really comfortable have running different commands to setup the environment (especially restarting the terminal). Do you think you can pack all the operations with a single command? You can always use Makefile. Try placing them under a single Makefile where you can run
make conda
andmake <next_thing>
- I remember you needed sudo privilages to install ngspice and klayout, not sure where the user need to enter the password in this process. Can you elaborate this info in the docs you edited and also it would be really good if you could add snapshots of it?
…ile_linux_ub22_for_ngspice.sh
Add files via upload
needs to be removed, keep hidden for now
needs to be removed, set as hidden for now
Changes include -
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comments. I think there is still some work that needs to be done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on ubuntu 22. works fine.
Final changes to klayout version completed
#225 (comment)