Fix problem of make not exiting on subprocess errors #250
Conversation
|
thanks for the PR @chetanyagoyal ! I think your updates are already tested on the ldo generator and cryo-gen checks here. I can see that the generator exited after hitting an error in placement and quit running till the end. |
This seems like a slightly more involved issue, so I think i'll look into that in another PR |
sounds good!. @msaligane this can be merged. To explain what this PR gives to the repo, this is mostly an enhancement for the generators flow. Earlier the generators run till the end eventhough they fail at some step. Now the generator exits after hitting an error in placement and quit running till the end. This will avoid that confusion for the users and also helps CI |
|
@chetanyagoyal , please update your PR so that we can merge this. |
Are you talking about fixing the printing order in the generators? |
|
If you can do that in this same PR, that would be great. But I was talking
about synchronizing your PR with the main repo
…On Sat, 4 Nov, 2023, 9:01 am Chetanya, ***@***.***> wrote:
@chetanyagoyal <https://github.com/chetanyagoyal> , please update your PR
so that we can merge this.
Are you talking about fixing the printing order in the generators?
—
Reply to this email directly, view it on GitHub
<#250 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYCOBKKMDNQMWWHTXDHROBDYCWZKFAVCNFSM6AAAAAA5Z2RSZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJTGMZDGOJSGA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
No description provided.