Canary checks for simulations in CI #284
Conversation
|
@msaligane Can you please look through this? |
|
Do you have a description of what is happening? |
| errors = { | ||
| 'frequency': { 'max': 1, 'min': 0.5 }, | ||
| 'power': { 'max': 1000, 'min': 1000 }, | ||
| 'error': { 'max': 100, 'min': 50 }, | ||
| } |
There was a problem hiding this comment.
@msaligane this dict of dicts stores the max and min allowable deviations (in percent) for each frequency, power and error results from the simulations. This is stored in generators/common so that all generators have access to it and there's no code redundancy.
The rest of the logic checks the deviation of the results in the currently generated file from the template file
- if it lies between max and min, amber alert (throws a soft warning)
- if it's greater than the max allowable deviation, red alert (raises a ValueErrorr)
- if it's less than the minimum allowable dev., green alert (nothing raised)
There was a problem hiding this comment.
It also incorporates the ngspice version into the warnings so that the maintainers can be notified if the simulation results are wildly different because of an ngspice version mismatch
There was a problem hiding this comment.
thanks, but my point is this needs to be a readme.
There was a problem hiding this comment.
I've already added function descriptions as docstrings. I'll make a README in generators/common for the entire folder then
There was a problem hiding this comment.
Resolved, can this be merged now?
delete parse_rpt.py file from temp-sense-gen top-level directory
No description provided.