Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RL refactor #333

Closed
wants to merge 9 commits into from
Closed

Conversation

alibillalhammoud
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@chetanyagoyal chetanyagoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the test1.py file
Otherwise LGTM!

@msaligane
Copy link
Member

Is this ready for review?

@msaligane
Copy link
Member

@alibillalhammoud

@alibillalhammoud
Copy link
Collaborator Author

@msaligane not yet. I am currently rerunning on a fresh machine to verify all package versions I have listed in the requirements file are correct. Should be ready by Monday.

@alibillalhammoud
Copy link
Collaborator Author

Ok all good now. This PR is ready to merge

@alibillalhammoud alibillalhammoud marked this pull request as ready for review August 25, 2024 20:10
openfasoc/MLoptimization/test1.py Outdated Show resolved Hide resolved
@chetanyagoyal
Copy link
Collaborator

Otherwise lgtm!

@chetanyagoyal
Copy link
Collaborator

@msaligane this can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants