Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adapt the project to GitHub #1

Merged
merged 34 commits into from
Jul 18, 2024
Merged

chore: adapt the project to GitHub #1

merged 34 commits into from
Jul 18, 2024

Conversation

Yannick-Dayer
Copy link
Collaborator

  • Removed remnants of GitLab (badges, URLs, and CI configurations);
  • Added a pre-commit hook to enforce conventional commit;
  • Fixed the license file and Reuse;
  • Added workflows configuration for GitHub Actions.

@Yannick-Dayer
chore(pre-commit): add conventional-pre-commit.
db38fed
@Yannick-Dayer
ci: remove the GitLab CI configuration.
6efe856
@Yannick-Dayer
chore(readme): change the url and badges.
caaae4e
@Yannick-Dayer
docs: update the doc source URLs and install URLs.
c930302
@Yannick-Dayer
chore: update the remaining project URLs
f66737c
@Yannick-Dayer
chore(pre-commit): auto-install 'commit-msg' hook.
bbcd3b2
@Yannick-Dayer
chore(QA): remove excludes from reuse pre-commit.
85b2880
@Yannick-Dayer
chore(QA): add a pixi hook to pre-commit. Update pixi.
5aee465
@Yannick-Dayer
chore(readme): fix the tests and coverage badges
a8e9090
@Yannick-Dayer
chore(license): add the year and owner in the license.
6bb24e0
@Yannick-Dayer
ci: rename pixi environment to "test-alternative".
00845cf
@Yannick-Dayer
ci: add the CI workflows for GitHub Actions.
b165fc4
@Yannick-Dayer
ci: add dynamic "runs-on" for matrix job.
fc2e0f0
@Yannick-Dayer
ci(docs): always add the preview link to new Pull Requests.
96ae936
@Yannick-Dayer
ci: prevent shallow git checkouts for versioningit.
1a30b3e
@Yannick-Dayer
ci: coverage-comment action requires relative files.
e8cdaff
@github-actions GitHub Actions
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@Yannick-Dayer Yannick-Dayer self-assigned this Jul 11, 2024
@Yannick-Dayer Yannick-Dayer requested review from anjos and 183amir and removed request for anjos July 12, 2024 11:57
@183amir
Copy link
Collaborator

183amir commented Jul 15, 2024

where is the readthedocs link to this pr?

@Yannick-Dayer
Copy link
Collaborator Author

I added the doc-preview workflow that adds the link after creating the Pull Request. As it adds the link on a pull_request.opened event, it did not trigger.

The readthedocs side is setup and working: https://clapper--1.org.readthedocs.build/en/1/
The link was not added for this one, but should be present in following pull requests descriptions.

183amir
183amir requested changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@183amir 183amir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good but there are some changes needed.

.github/workflows/tests.yaml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
.github/workflows/deploy_pypi.yml Outdated Show resolved Hide resolved
@Yannick-Dayer Yannick-Dayer reopened this Jul 15, 2024
@Yannick-Dayer
ci(pixi): specify the environment for run commands
80729c0
@Yannick-Dayer
chore: fix pyproject.toml command and dependencies
79ca807 
Docs commands should not have a dependency on the doc-clean command;
Conda dependencies are managed externally.
@Yannick-Dayer
ci: build and install the package during the tests
652520f 
Add a job in tests.yaml that builds the package and installs the wheel.
This should ensures the release package can also be built correctly.
183amir
183amir requested changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@183amir 183amir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks better however some pixi related changes are needed.

.github/dependabot.yml Show resolved Hide resolved
pixi.lock Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
183amir
183amir approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@183amir 183amir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, looks great! Would be nice if you could put exact changes in gridtk too.

@Yannick-Dayer
Copy link
Collaborator Author

And thank you for the review!

I will create a pull request in gridtk with these changes 👍🏼

@Yannick-Dayer Yannick-Dayer merged commit a440cc0 into main Jul 18, 2024
10 checks passed
@Yannick-Dayer Yannick-Dayer deleted the github-transition branch July 18, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@183amir 183amir 183amir approved these changes

Assignees

@Yannick-Dayer Yannick-Dayer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yannick-Dayer @183amir