Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix the coverage reports not being retrieved correctly #9

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

Yannick-Dayer
Copy link
Collaborator

@Yannick-Dayer Yannick-Dayer commented Sep 25, 2024

  • Include hidden files when creating artifacts from coverage reports (merging coverage reports with other names is not supported).
  • Trigger an error early when no coverage report is found instead of failing when trying to load a missing file.

related issue on coverage-comment-action.

Fixes #7.


📚 Documentation preview 📚: https://clapper--9.org.readthedocs.build/en/9/

Trigger an error early when no coverage report is found instead of
failing when trying to load a missing file.
The upload-artifacts action won't upload hidden files by default.
Force the inclusion of hidden files as it is required by merge-coverage.
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@Yannick-Dayer Yannick-Dayer marked this pull request as ready for review September 25, 2024 20:04
Copy link
Member

@anjos anjos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anjos anjos merged commit 40dfce6 into main Sep 25, 2024
10 checks passed
@anjos anjos deleted the fix/ci-coverage branch September 25, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] No coverage report found after the test steps
2 participants