[ refactor ] Improve error handling in Core
#3434
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spcfox
force-pushed
the
cg-error-handle
branch
from
d89dd5a to
49fd711
Compare
gallais
reviewed
Dec 3, 2024
spcfox
commented
Dec 3, 2024
spcfox
commented
Dec 9, 2024
spcfox
force-pushed
the
cg-error-handle
branch
from
b3320e9 to
8c60a6e
Compare
|
This PR is ready for review. The lsp build is failing because I deleted |
|
If my refactoring is questionable, I can put everything related to #3427 in a separate PR to simplify the review |
spcfox
force-pushed
the
cg-error-handle
branch
from
8c60a6e to
5135ae4
Compare
…ir` and `changeDir`
spcfox
force-pushed
the
cg-error-handle
branch
3 times, most recently
from
55392d1 to
3f15823
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Core.NonZeroExitCode,SystemError,CodegenNotFound,UnsupportedOpertaion.coreLift_calls replaced by explicit result processing.MaybefromcompileExprandincCompileFilesignatures. Instead of returningNothing,throwis used. Earlier both variants were found in the code. Usingthrowallows you to pass a more clear error.--exec#3427: the--execcommand returns the program exit code. If several--execoptions are passed, the result of the last execution will be returned.CompilationFailedfromREPLResult. More specific errors usingthroware returned instead.Should this change go in the CHANGELOG?
implementation, I have updated
CHANGELOG_NEXT.md(and potentially alsoCONTRIBUTORS.md).