Add Ci and automated code formatter as well as linting tool #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-ober
requested review from
sebastian-peter,
GJawana,
noffermann and
danielfeismann
# Conflicts: # markovs_household/data/household.py # poetry.lock # pyproject.toml
sebastian-peter
requested changes
Jun 20, 2022
There was a problem hiding this comment.
Looks great, thanks for the effort!
If I may express a wish, it'd be to also inlcude isort :)
It can be configured to nicely play together with black.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #49
With flake8 you can test your code formatting from the command line with
flake8.With black typing
black .in the command line should resolve all code formatting issues (this works like spotless).