Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Irradiation / Irradiance #268

Merged
merged 13 commits into from
Dec 18, 2020
Merged

Fix Irradiation / Irradiance #268

merged 13 commits into from
Dec 18, 2020

Conversation

johanneshiry
Copy link
Member

Resolves #266

@johanneshiry
- adapt StandardUnits to account for valid irradiance and irradiation
5c909cb 
- introduce new SolarIrradianceValue
- fix IrradiationValue to valid unit
- adapt factories accordingly
@johanneshiry johanneshiry added the bug Something isn't working label Dec 17, 2020
@johanneshiry johanneshiry added this to the Version 2.0 milestone Dec 17, 2020
@johanneshiry johanneshiry requested a review from ckittl December 17, 2020 14:43
@johanneshiry johanneshiry self-assigned this Dec 17, 2020
@johanneshiry johanneshiry marked this pull request as draft December 17, 2020 14:43
@johanneshiry johanneshiry marked this pull request as ready for review December 17, 2020 15:58
@codecov
Copy link

codecov bot commented Dec 17, 2020 •
edited
Loading

Codecov Report

Merging #268 (e873613) into dev (2ad24b6) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #268      +/-   ##
============================================
- Coverage     77.76%   77.75%   -0.01%     
+ Complexity     1923     1922       -1     
============================================
  Files           241      241              
  Lines          7830     7827       -3     
  Branches        747      747              
============================================
- Hits           6089     6086       -3     
  Misses         1321     1321              
  Partials        420      420
Impacted Files Coverage Δ Complexity Δ
...y/timeseries/IconTimeBasedWeatherValueFactory.java 95.00% <0.00%> (-0.24%) 10.00% <0.00%> (ø%)
...n/java/edu/ie3/datamodel/models/StandardUnits.java 96.00% <0.00%> (-0.08%) 1.00% <0.00%> (ø%)
...a/edu/ie3/datamodel/models/value/WeatherValue.java 61.90% <0.00%> (ø) 7.00% <0.00%> (ø%)
...l/io/processor/timeseries/TimeSeriesProcessor.java 97.08% <0.00%> (ø) 21.00% <0.00%> (ø%)
...actory/timeseries/TimeBasedSimpleValueFactory.java 100.00% <0.00%> (ø) 16.00% <0.00%> (ø%)
...y/timeseries/PsdmTimeBasedWeatherValueFactory.java 100.00% <0.00%> (ø) 7.00% <0.00%> (ø%)
...u/ie3/datamodel/models/value/IrradiationValue.java
...3/datamodel/models/value/SolarIrradianceValue.java 80.00% <0.00%> (ø) 9.00% <0.00%> (?%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fbe514...e873613. Read the comment docs.

ckittl
ckittl suggested changes Dec 17, 2020
View reviewed changes
src/main/java/edu/ie3/datamodel/models/value/IrradiationValue.java Outdated Show resolved Hide resolved
docs/readthedocs/models/models.rst Outdated Show resolved Hide resolved
docs/uml/main/TimeSeriesDatamodelConcept.puml Outdated Show resolved Hide resolved
src/main/java/edu/ie3/datamodel/io/factory/timeseries/IconTimeBasedWeatherValueFactory.java Outdated Show resolved Hide resolved
src/main/java/edu/ie3/datamodel/io/factory/timeseries/PsdmTimeBasedWeatherValueFactory.java Show resolved Hide resolved
...t/groovy/edu/ie3/datamodel/io/factory/timeseries/IconTimeBasedWeatherValueFactoryTest.groovy Show resolved Hide resolved
src/main/java/edu/ie3/datamodel/io/factory/timeseries/PsdmTimeBasedWeatherValueFactory.java Outdated Show resolved Hide resolved
@johanneshiry johanneshiry requested a review from ckittl December 18, 2020 10:32
@ckittl ckittl merged commit d576430 into dev Dec 18, 2020
@ckittl ckittl deleted the jh/#266-fix-irradiance-irradiation branch December 18, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckittl ckittl ckittl approved these changes

Assignees

@johanneshiry johanneshiry

Labels
bug Something isn't working
Projects
None yet
Milestone
Version 2.0
Development

Successfully merging this pull request may close these issues.

Fix Irradiance/Irradiation
2 participants
@johanneshiry @ckittl