Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt column scheme of ICON weather data #329

Merged
merged 22 commits into from
Mar 4, 2022

Conversation

ckittl
Copy link
Member

@ckittl ckittl commented Apr 16, 2021

Closes #267. Close #321 beforehand.

Adapting the ICON weather data scheme + integration tests with various technologies + minor improvements.

@ckittl ckittl added bug Something isn't working enhancement New feature or request labels Apr 16, 2021
@ckittl ckittl added this to the Version 2.0 milestone Apr 16, 2021
@ckittl ckittl requested a review from a team April 16, 2021 11:01
@ckittl ckittl self-assigned this Apr 16, 2021
@ckittl
Copy link
Member Author

ckittl commented Apr 16, 2021

!test

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #329 (4b2243d) into dev (e716924) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #329      +/-   ##
============================================
- Coverage     78.05%   77.99%   -0.06%     
- Complexity     2102     2105       +3     
============================================
  Files           257      257              
  Lines          8401     8398       -3     
  Branches        815      813       -2     
============================================
- Hits           6557     6550       -7     
- Misses         1441     1445       +4     
  Partials        403      403              
Impacted Files Coverage Δ Complexity Δ
...odel/io/source/influxdb/InfluxDbWeatherSource.java 82.17% <0.00%> (-5.60%) 22.00% <0.00%> (+1.00%) ⬇️
...models/timeseries/repetitive/LoadProfileInput.java 40.90% <0.00%> (-2.57%) 2.00% <0.00%> (-1.00%)
.../ie3/datamodel/io/connectors/CsvFileConnector.java 75.59% <0.00%> (-1.79%) 32.00% <0.00%> (-1.00%)
...el/io/source/couchbase/CouchbaseWeatherSource.java 72.09% <0.00%> (-1.08%) 14.00% <0.00%> (+1.00%) ⬇️
...ctory/timeseries/TimeBasedWeatherValueFactory.java 100.00% <0.00%> (ø) 6.00% <0.00%> (+3.00%)
...y/timeseries/PsdmTimeBasedWeatherValueFactory.java
.../timeseries/CosmoTimeBasedWeatherValueFactory.java 100.00% <0.00%> (ø) 6.00% <0.00%> (?%)
.../ie3/datamodel/io/source/sql/SqlWeatherSource.java 79.00% <0.00%> (+0.18%) 18.00% <0.00%> (-2.00%) ⬆️
.../models/input/thermal/CylindricalStorageInput.java 86.88% <0.00%> (+1.63%) 12.00% <0.00%> (+1.00%)
...du/ie3/datamodel/models/timeseries/TimeSeries.java 30.00% <0.00%> (+5.00%) 4.00% <0.00%> (+1.00%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7b1587...4b2243d. Read the comment docs.

@ckittl ckittl force-pushed the ck/#267-adaptColumnSchemeOfICONWeatherData branch from 2aa1823 to 4b2243d Compare April 21, 2021 09:21
@t-ober t-ober merged commit 689cb3e into dev Mar 4, 2022
@sebastian-peter sebastian-peter deleted the ck/#267-adaptColumnSchemeOfICONWeatherData branch March 4, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix PsdmTimeBasedWeatherValueFactory
3 participants